Skip to content

Conversation

@Steven-Eardley
Copy link
Contributor

@Steven-Eardley Steven-Eardley commented Dec 8, 2024

Fix app init issues for test server automation

  • I've added a method to download the test users CSV from google sheets and import those within the anon_import script
  • Refactored the patch_config function out of tests module, so that we don't create the LCC index when importing that function (long story)
  • IMPORTANT - the app now initialises the index using an aliases pattern. This should be backward compatible with old indexes (these sill need manual deletion to migrate)

Auto load test users in anon_import script

Improve test server init

Requires Test User CSV download URL to be set in dev.cfg - already pushed to test secrets.

This PR...

  • has scripts to run
  • has migrations to run
  • adds new infrastructure
  • changes the CI pipeline
  • affects the public site
  • affects the editorial area
  • affects the publisher area
  • affects the monitoring

Developer Checklist

Developers should review and confirm each of these items before requesting review

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Project's coding standards are met
    • No deprecated methods are used
    • No magic strings/numbers - all strings are in constants or messages files
    • ES queries are wrapped in a Query object rather than inlined in the code
    • Where possible our common library functions have been used (e.g. dates manipulated via dates)
    • Cleaned up commented out code, etc
    • Urls are constructed with url_for not hard-coded
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested
  • There is a recent merge from develop

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section should be duplicated for each reviewer

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Project's coding standards are met
    • No deprecated methods are used
    • No magic strings/numbers - all strings are in constants or messages files
    • ES queries are wrapped in a Query object rather than inlined in the code
    • Where possible our common library functions have been used (e.g. dates manipulated via dates)
    • Cleaned up commented out code, etc
    • Urls are constructed with url_for not hard-coded
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested
  • There is a recent merge from develop

Testing

List user test scripts that need to be run

List any non-unit test scripts that need to be run by reviewers

Deployment

What deployment considerations are there? (delete any sections you don't need)

Configuration changes

new config key to download test user CSV

Scripts

What scripts need to be run from the PR (e.g. if this is a report generating feature), and when (once, regularly, etc).

Migrations

What migrations need to be run to deploy this

Monitoring

What additional monitoring is required of the application as a result of this feature

New Infrastructure

What new infrastructure does this PR require (e.g. new services that need to run on the back-end).

Continuous Integration

What CI changes are required for this

@Steven-Eardley Steven-Eardley marked this pull request as ready for review December 12, 2024 12:52
@Steven-Eardley Steven-Eardley force-pushed the feature/2024-12-05_auto_anon_import branch from eb463aa to 97ec229 Compare February 11, 2025 12:51
Copy link
Contributor

@RK206 RK206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good to me

@Steven-Eardley Steven-Eardley merged commit 63b57b0 into develop Feb 12, 2025
1 of 2 checks passed
@Steven-Eardley Steven-Eardley deleted the feature/2024-12-05_auto_anon_import branch February 12, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants